DHCPLEASEACTIVE response failed on 4.1-ESV-R4 and 4.2.3-P2

[Naoki Wakamatsu]

Hi

ISC DHCP 4.1-ESV-R4 and 4.2.3-P2 with a leasequery option fails to response
DHCPLEASEACTIVE message in most case.  (4.1-ESV-R2 and 4.2.1 has no problem.)
The error message is as follows:
    Impossible condition at dhcpleasequery.c:492.

This thread discussed this error.
https://lists.isc.org/pipermail/dhcp-users/2011-October/014144.html


The issue is improved by removing the following if statement.  Is this necessary?

diff -r -c dhcp-4.2.3-P1.orig/server/dhcpleasequery.c dhcp-4.2.3-P1/server/dhcpleasequery.c
*** dhcp-4.2.3-P1.orig/server/dhcpleasequery.c	2011-04-22 22:30:14.000000000 +0900
--- dhcp-4.2.3-P1/server/dhcpleasequery.c	2012-01-20 05:23:46.937492573 +0900
***************
*** 487,500 ****
  		}
  
  		if (lease->ends > cur_time) {
- 			if (time_expiry < cur_time) {
- 				log_error("Impossible condition at %s:%d.",
- 					  MDL);
- 
- 				option_state_dereference(&options, MDL);
- 				lease_dereference(&lease, MDL);
- 				return;
- 			}
  			time_expiry = htonl(lease->ends - cur_time);
  			if (!add_option(options, 
  					DHO_DHCP_LEASE_TIME,
--- 487,492 ----


Best regards,