Patch provided, please review!: Re: DNSTAP doesn't purge old dnstap files

[Jesus Cea]

On 21/3/23 23:38, Jesus Cea wrote:
> Hi everybody.
> 
> Bind 9.16 here.
> 
> I have this configuration for DNSTAP:
> 
> """
>    dnstap {auth; client; resolver; forwarder;};
>    dnstap-output file "/var/cache/bind/dnstap.tap" size 100M versions 
> 100 suffix timestamp;
> """
> 
> The "dnstap.tap" is correctly moved to "dnstap.tap.TIMESTAMP" a new 
> "dnstap.tap" file is created when the old one reaches 100MB in size, but 
> bind is not purging old "dnstap.tap.TIMESTAMP" files when their count 
> goes over 100. It doesn't delete all files at all.

I have invested an afternoon debugging this and I have a diagnostic and 
a trivial patch: Please, review: 
https://gitlab.isc.org/isc-projects/bind9/-/issues/3959

-- 
Jesús Cea Avión                         _/_/      _/_/_/        _/_/_/
jcea at jcea.es - https://www.jcea.es/    _/_/    _/_/  _/_/    _/_/  _/_/
Twitter: @jcea                        _/_/    _/_/          _/_/_/_/_/
jabber / xmpp:jcea at jabber.org  _/_/  _/_/    _/_/          _/_/  _/_/
"Things are not so easy"      _/_/  _/_/    _/_/  _/_/    _/_/  _/_/
"My name is Dump, Core Dump"   _/_/_/        _/_/_/      _/_/  _/_/
"El amor es poner tu felicidad en la felicidad de otro" - Leibniz