Ubuntu service file is missing Restart parameter

[Petr Menšík]

Hi Blažej,

Just my 2 cents:

I think Restart=on-failure is not a good default value. named.service 
may fail for different reasons. If the reason is configuration failure, 
I do not think it should retry many times only to result to sleep before 
another retries. Until manual configuration change, this won't work. I 
would not recommend using that on distribution package.

On the other hand, Restart=on-abnormal might help in few specific cases. 
Sending SIGSEGV signal or occasional trigger of assertion failure would 
be still catched by it and the service would be restarted. But it won't 
restart when the port is already taken, address is not available or typo 
in configuration were made. I think that is a good default value and I 
plan it including into Fedora and later RHEL updates.

Anyway, bind9 repository does not contain any systemd unit file, so such 
requests have to be directed to whatever source it were used. I admit 
contributing fine tuned default service file might be good idea, I guess 
differences should not be significant between distributions.

Regards,
Petr

On 2/5/23 15:46, Blažej Krajňák wrote:
> Hi Ondrej,
>
> sorry, I really thought it's clear enough, but as I just found, the
> problem presents in releases for Ubuntu 20.04, 18.04 and maybe older
> also.
>
> It's all about the content of /lib/systemd/system/named.service
>
> Release for Ubuntu Jammy 22.04 LTS (1:9.18.1-1ubuntu1.3) contains
> "Restart=on-failure" parameter.
>
> Releases for
>      Ubuntu Focal 20.04 LTS (1:9.16.1-0ubuntu2.12)
>      Ubuntu Bionic 18.04 LTS (1:9.11.3+dfsg-1ubuntu1.18)
> and maybe older also are missing "Restart" parameter.
>
> I found this problem with friend, when Bind9 on Ubuntu 20.04 exited
> with SIGV signal and keeps down (systemd did not restart the service).
>
>
> Thanks
>
>
> ne 5. 2. 2023 o 14:18 Ondřej Surý <ondrej at isc.org> napísal(a):
>> Hi,
>>
>> it might seem like we do practice black magic, but we really don’t. Thus we can’t really help if you don’t provide more details like the content of the file, the source of the package(s), and the version of the package(s).
>>
>> Ondrej
>> --
>> Ondřej Surý — ISC (He/Him)
>>
>> My working hours and your working hours may be different. Please do not feel obligated to reply outside your normal working hours.
>>
>>> On 5. 2. 2023, at 13:29, Blažej Krajňák <blazej.krajnak at gmail.com> wrote:
>>>
>>> Hi there,
>>>
>>> I just discovered that default Bind9 systemd service file for Ubuntu
>>> is missing "Restart" parameter. Is there any reason?
>>> Service file for Debian contains "Restart=on-failure"
>>>
>>>
>>> Thanks
>>> Blažej
>>> --
>>> Visit https://lists.isc.org/mailman/listinfo/bind-users to unsubscribe from this list
>>>
>>> ISC funds the development of this software with paid support subscriptions. Contact us at https://www.isc.org/contact/ for more information.
>>>
>>>
>>> bind-users mailing list
>>> bind-users at lists.isc.org
>>> https://lists.isc.org/mailman/listinfo/bind-users

-- 
Petr Menšík
Software Engineer, RHEL
Red Hat, https://www.redhat.com/
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB