Building contrib modules for 9.18.2 fails

[Michal Nowak]

On 25/04/2022 12:20, Josef Moellers wrote:
> Hi,
> 
> I'm trying to build bind 9.18.2 with the contrib modules, but this fails 
> for contrib/dlz/modules/wildcard.
> 
> Without any modifications to the spec file used for 9.18.1, it fails 
> because it does not have "FALLTHROUGH" and "UNREACHABLE()", whose use is 
> new in 9.18.2, defined.
> 
> I tried to solve this by including <isc/util.h> and adding 
> "-I../../../../lib/isc/include" to the CFLAGS in the Makefile but
> that then fails because the modules have a simpler definition of 
> "isc_result_t"
> 
> My code to build the modules is:
> # special build for the plugins
> for d in contrib/dlz/modules/*; do
>          [ -e $d/Makefile ] && make -C $d
> done
> 
> Any tips/hints what I'm doing wrong?
> 
> Thanks in advance,
> 
> Josef

Looks like issue with commits 128c550a955635e4ff78f120eb6c94411a2f163d 
and c62a94363d7707f0354a2291de546d7f87ea58d9 we did not catch because we 
don't build contrib/ in the CI. The stuff in the directory in not 
supported, but will be fixed as time permits, if you file an issue to 
GitLab.

As a stopgap measure you can revert those two commits above just for the 
contrib/dlz/modules/wildcard/dlz_wildcard_dynamic.c file. Then it builds 
for me.

Michal