Error: zone example.com/IN (signed): receive_secure_serial: unchanged

[Tony Finch]

Tom <tomtux007 at gmail.com> wrote:
>
> DNSSEC is working fine on the zone "example.com", but as I mentioned: The
> severity is "error" and it's not clear why.

It looks to me like the code is re-using its error path clean-up in a case
where there is nothing to do, and if it is as simple as that then the
patch below should suppress the unwanted logging.

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index df39dfb4d0..09d7528711 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -14528,9 +14528,10 @@ receive_secure_serial(isc_task_t *task,
isc_event_t *event) {
 		result = sync_secure_journal(zone, zone->rss_raw, rjournal,
 					     start, end, &soatuple,
 					     &zone->rss_diff);
-		if (result == DNS_R_UNCHANGED)
+		if (result == DNS_R_UNCHANGED) {
+			result = ISC_R_SUCCESS;
 			goto failure;
-		else if (result != ISC_R_SUCCESS)
+		} else if (result != ISC_R_SUCCESS)
 			CHECK(sync_secure_db(zone, zone->rss_raw, zone->rss_db,
 					     zone->rss_oldver, &soatuple,
 					     &zone->rss_diff));


Tony.
-- 
f.anthony.n.finch  <dot at dotat.at>  http://dotat.at/
public services available on equal terms to all