Does BIND-9.9.9-P1 change the control command log to not show the zone name?

[Tuan Vo]

Ok, thanks. Got it.

Thanks,
Tuan Vo

-----Original Message-----
From: Mark Andrews [mailto:marka at isc.org] 
Sent: Monday, June 13, 2016 6:36 AM
To: Tuan Vo <vhtuan at tma.com.vn>
Cc: bind-users at isc.org
Subject: Re: Does BIND-9.9.9-P1 change the control command log to not show
the zone name?


It is a unintentional side effect of the change.  Changing 'command'
to 'cmdline' should fix it.  This is from master where there are two
instances that need fixing.  Only the second hunk should be needed for 9.9.x

diff --git a/bin/named/control.c b/bin/named/control.c index
75fc278..d947ebb 100644
--- a/bin/named/control.c
+++ b/bin/named/control.c
@@ -147,7 +147,7 @@ ns_control_docommand(isccc_sexpr_t *message,
isc_boolean_t readonly,
                isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
                              NS_LOGMODULE_CONTROL, log_level,
                              "rejecting restricted control channel "
-                             "command '%s'", command);
+                             "command '%s'", cmdline);
                result = ISC_R_FAILURE;
                goto cleanup;
        }
@@ -155,7 +155,7 @@ ns_control_docommand(isccc_sexpr_t *message,
isc_boolean_t readonly,
        isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
                      NS_LOGMODULE_CONTROL, log_level,
                      "received control channel command '%s'",
-                     command);
+                     cmdline);
 
        if (command_compare(command, NS_COMMAND_RELOAD)) {
                result = ns_server_reloadcommand(ns_g_server, lex, text);


In message <001201d1c4af$6b3659e0$41a30da0$@tma.com.vn>, "Tuan Vo" writes:
> 
> When running the rndc command, the log doesn't show the zone name.
Example:
> 
>  
> 
> # rndc -c rndc.conf freeze nguoianphu.com
> 
> # rndc -c rndc.conf thaw nguoianphu.com
> 
> The zone reload and thaw was successful.
> 
>  
> 
> The logs:
> 
>  
> 
> 12-Jun-2016 19:51:06.793 received control channel command 'freeze'
> 
> 12-Jun-2016 19:51:06.794 freezing zone nguoianphu.com/IN': success
> 
> 12-Jun-2016 19:51:10.124 received control channel command 'thaw'
> 
> 12-Jun-2016 19:51:10.124 thawing zone nguoianphu.com/IN': success
> 
>  
> 
> In past, it should be:
> 
>  
> 
> 12-Jun-2016 19:51:06.793 received control channel command 'freeze 
> nguoianphu.com'
> 
> 12-Jun-2016 19:51:06.794 freezing zone nguoianphu.com/IN': success
> 
> 12-Jun-2016 19:51:10.124 received control channel command 'thaw 
> nguoianphu.com'
> 
> 12-Jun-2016 19:51:10.124 thawing zone nguoianphu.com/IN': success
> 
>  
> 
> Does BIND-9.9.9-P1 just want to show the command name, not the zone name?
> Code change here:
> 
>  
> 
> https://source.isc.org/cgi-bin/gitweb.cgi?p=bind9.git;a=blobdiff;f=bin
> /named
> /control.c;h=b1b744f2ceabf4bdeb706e3c5f145adc0d6a0843;hp=aacb0884fde0a
> 85b386
> 0f37c70714bde1e49ac22;hb=3bbb17429d53ba42ef9356c9b5dfcbf5d9647fcc;hpb=
> 6cd768
> 47a19cbafadad349fd90a216e8807bc461
> 
>  
> 
> Thanks,
> 
> Tuan Vo
--
Mark Andrews, ISC
1 Seymour St., Dundas Valley, NSW 2117, Australia
PHONE: +61 2 9871 4742                 INTERNET: marka at isc.org