IXFR & manually edited zone files

[David Coulthart]

On Mar 8, 2011, at 3:44 PM, Mark Andrews wrote:
> In message <B840935F-4809-40CF-98C5-029CBBAB48EF at columbia.edu>, David Coulthart
> writes:
>> It looks like the problem is with setting ixfr-from-differences to master.  I
>> f I instead set the option to yes, a journal file is generated & IXFR works c
>> orrectly.
...
>> Is this a bug in BIND?
> 
> Index: bin/named/zoneconf.c
> ===================================================================
> RCS file: /proj/cvs/prod/bind9/bin/named/zoneconf.c,v
> retrieving revision 1.171.34.2
> diff -u -r1.171.34.2 zoneconf.c
> --- bin/named/zoneconf.c	7 Mar 2011 04:16:39 -0000	1.171.34.2
> +++ bin/named/zoneconf.c	8 Mar 2011 20:44:00 -0000
> @@ -1077,10 +1077,10 @@
> 		INSIST(result == ISC_R_SUCCESS && obj != NULL);
> 		if (cfg_obj_isboolean(obj))
> 			ixfrdiff = cfg_obj_asboolean(obj);
> -		else if (strcasecmp(cfg_obj_asstring(obj), "master") &&
> +		else if (!strcasecmp(cfg_obj_asstring(obj), "master") &&
> 			 ztype == dns_zone_master)
> 			ixfrdiff = ISC_TRUE;
> -		else if (strcasecmp(cfg_obj_asstring(obj), "slave") &&
> +		else if (!strcasecmp(cfg_obj_asstring(obj), "slave") &&
> 			ztype == dns_zone_slave)
> 			ixfrdiff = ISC_TRUE;
> 		else

Thank you very much, Mark. I've confirmed this patch fixes the problem.  

Thanks,
Dave Coulthart