excessive notify traffic (8.2.3)

[Nick Simicich]

There has been offlist discussion, but the short summary is:

The notify storms Craig and I were seeing were caused by NS records pointing to CNAMES.  The patch fixes it.  I'm running with the patch on 8.2.3 now and the patch seems to work fine.  It also works to not have any NS records pointed to by CNAMES.

Thanks, Mark!

This problem has been reported a couple of times and it looks like it is finally quashed.

At 02:58 PM 3/7/2001 +1100, Mark.Andrews at nominum.com wrote:
>
>	Try the following patch.
>
>	Mark
>
>Index: bin/named/ns_notify.c
>===================================================================
>RCS file: /proj/cvs/isc/bind8/src/bin/named/ns_notify.c,v
>retrieving revision 8.12
>diff -u -r8.12 ns_notify.c
>--- ns_notify.c	2000/12/23 08:14:40	8.12
>+++ ns_notify.c	2001/03/07 03:56:31
>@@ -352,6 +352,7 @@
> 	struct in_addr nss[NSMAX];
> 	struct hashbuf *htp;
> 	int is_us, nsc;
>+	int cname = 0;
> 
> 	htp = hashtab;
> 	anp = nlookup(aname, &htp, &fname, 0);
>@@ -361,6 +362,15 @@
> 		for (adp = anp->n_data; adp; adp = adp->d_next) {
> 			struct in_addr ina;
> 
>+			if (match(adp, class, T_CNAME)) {
>+				cname = 1;
>+				ns_error(ns_log_notify,
>+					 "NS '%s' for '%s/%s' is a CNAME",
>+					 *aname ? aname : ".",
>+					 *dname ? dname : ".",
>+					 p_class(class));
>+				break;
>+			}
> 			if (!match(adp, class, T_A))
> 				continue;
> 			if (adp->d_type == ns_t_sig)
>@@ -374,7 +384,7 @@
> 				nss[nsc++] = ina;
> 		} /*next A*/
> 	if (nsc == 0) {
>-		if (!is_us && !NS_OPTION_P(OPTION_NOFETCHGLUE)) {
>+		if (!is_us && !cname && !NS_OPTION_P(OPTION_NOFETCHGLUE)) {
> 			struct qinfo *qp;
> 
> 			qp = sysquery(aname, class, ns_t_a, 0, 0, ns_port,
>> 
>> I recently migrated our DNS from an old SunOS box to a new
>> Debian box.  All seems to work fine, except that the primary
>> sends out NOTIFY messages about every 10 seconds for the 3
>> zones for which it is master.  Any ideas what might be wrong?
>> 
>> --- named.conf ---
>> 
>> options {
>>         directory "/var/cache/bind";
>> };
>> 
>> logging {
>>         category lame-servers { null; };
>>         category cname { null; };
>> };
>> 
>> zone "." {
>>         type hint;
>>         file "/etc/bind/db.root";
>> };
>> 
>> zone "localhost" {
>>         type master;
>>         file "/etc/bind/db.local";
>> };
>> 
>> zone "127.in-addr.arpa" {
>>         type master;
>>         file "/etc/bind/db.127";
>> };
>> 
>> zone "0.in-addr.arpa" {
>>         type master;
>>         file "/etc/bind/db.0";
>> };
>> 
>> zone "255.in-addr.arpa" {
>>         type master;
>>         file "/etc/bind/db.255";
>> };
>> 
>> zone "129.105.129.in-addr.arpa" {
>>         type master;
>>         file "/etc/bind/db.129.105.129";
>> };
>> 
>> zone "earth.nwu.edu" {
>>         type master;
>>         file "/etc/bind/db.earth.nwu";
>> };
>> 
>> zone "earth.northwestern.edu" {
>>         type master;
>>         file "/etc/bind/db.earth.northwestern";
>> };
>> 
>> zone "98.105.129.in-addr.arpa" {
>>         type slave;
>>         file "bak.129.105.98";
>>         masters {   
>>                 129.105.98.26;
>>         };
>> };
>> 
>> zone "isp.nwu.edu" {
>>         type slave;
>>         file "bak.isp.nwu";
>>         masters {
>>                 129.105.98.26;
>>         };
>> };
>> 
>> zone "isp.northwestern.edu" {
>>         type slave;
>>         file "bak.isp.northwestern";
>>         masters {
>>                 129.105.98.26;
>>         };
>> };
>> 
>--
>Mark Andrews, Nominum Inc.
>1 Seymour St., Dundas Valley, NSW 2117, Australia
>PHONE: +61 2 9871 4742                 INTERNET: Mark.Andrews at nominum.com
>
>
--
We will fight for bovine freedom, And hold our large heads high.
We will run free, with the buffalo or die! Cows with Guns.
 - Dana Lyons, Cows With Guns
Nick Simicich mailto:njs at scifi.squawk.com
http://scifi.squawk.com/njs.html -- Stop by and Light Up The World!