dhcpleasequery problems - 4.2.2

[Shawn Routhier]

On Oct 17, 2011, at 12:10 PM, Jack Kielsmeier wrote:

> Hello,
> 
> We are running ISC DHCP 4.2.2 in a redundant fashion (failover peer) in
> Solaris 11 zones (compiled from source).
> 
> Recently, we have determined that we need to make use of the DHCP leasequery
> option. In testing, we notice the following occurring in our logs:
> 
> ------------ LOGS ------------
> 
> Oct 17 13:19:03 dhcp-dsm dhcpd: [ID 702911 local5.error] Impossible
> condition at dhcpleasequery.c:492.
> Oct 17 13:19:09 dhcp-dsm dhcpd: [ID 702911 local5.error] Impossible
> condition at dhcpleasequery.c:492.
> Oct 17 13:19:15 dhcp-dsm dhcpd: [ID 702911 local5.error] Impossible
> condition at dhcpleasequery.c:492.
> Oct 17 13:19:21 dhcp-dsm dhcpd: [ID 702911 local5.error] Impossible
> condition at dhcpleasequery.c:492.
> Oct 17 13:22:34 dhcp-dsm dhcpd: [ID 702911 local5.error] Impossible
> condition at dhcpleasequery.c:492.
> Oct 17 13:22:39 dhcp-dsm dhcpd: [ID 702911 local5.error] Impossible
> condition at dhcpleasequery.c:492.
> 
> ------------ END LOGS ------------
> 
I think you want line 492 not 432

> Line 432 looks like this:
> 
> lease_dereference(&lease, MDL);
> 
> 

Line 492 deals with checking the lease ends time against the
current time.  It also appears to have a bug.  I'll have to go look
at the history to figure out what it thinks it's doing.

It appears that you can simply remove the code from 490 to 498
	if (time_expiry < cur_time {
		stuff
	}

But I haven't tested that or verified that the time_expiry isn't
being used in some odd way I don't understand yet.  If you do
test it we would be interested in the results.

> Any assistance with this matter would be greatly appreciated. I do not know
> what else to provide (such as the entire dhcpd.conf file, which is pretty
> long).
> 
> Thank You,
> 
> -
> Jack Kielsmeier
> netINS Systems Administrator
> systems at netins.net
>